Support for protocol 80949 (v5.0.0) #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoicLoofah
requested changes
Jul 31, 2020
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
It looks like the build for styles on reader.py isn't passing. Did you run black on that file?
Thanks for tackling this so quickly!
sc2reader/resources.py
Outdated
Collaborator
There was a problem hiding this comment.
Can you update this line as well to have a max build to be in line with the others above?
sc2reader/resources.py
Outdated
Contributor
Author
|
Should be good now. And yeah I forgot about |
StoicLoofah
approved these changes
Jul 31, 2020
Collaborator
StoicLoofah
left a comment
StoicLoofah
left a comment
There was a problem hiding this comment.
Great work. Thanks so much! I'll merge this in and mark a new release version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #121