Skip to content

Fix LotV apm #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix LotV apm #12

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
604e629
Fix LotV apm by squeezing events into rescaled game minutes.
nickelsen Apr 21, 2016
d8fa276
Test for LotV apm fix.
nickelsen Apr 21, 2016
f762293
Move multipliers into constants and make calulations easier to read.
nickelsen Apr 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test for LotV apm fix.
  • Loading branch information
@nickelsen
nickelsen committed Apr 21, 2016
commit d8fa276e161ff6ba04756f0b4de7dee0a27ff32b
11 changes: 11 additions & 0 deletions test_replays/test_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,17 @@ def test_lotv_time(self):
self.assertEqual(replay.length.seconds, 1002)
self.assertEqual(replay.real_length.seconds, 1002)

def test_lotv_apm(self):
from sc2reader.factories.plugins.replay import APMTracker, SelectionTracker, toJSON
factory = sc2reader.factories.SC2Factory()
factory.register_plugin("Replay", APMTracker())
replay = factory.load_replay("test_replays/lotv/lotv1.SC2Replay")
for player in replay.players:
from pprint import pprint
pprint(player)
if player.name == 'Zenchii':
self.assertTrue(int(player.avg_apm) == 56)


class TestGameEngine(unittest.TestCase):
class TestEvent(object):
Expand Down