Skip to content

Fixes toJson in sc2reader/scripts/sc2json.py #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Fixes toJson in sc2reader/scripts/sc2json.py #118

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a32c33
fix toDict in replay plugin
rohits47 Jul 6, 2020
54b0cc1
Update sc2reader/scripts/sc2json.py
rohits47 Jul 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update sc2reader/scripts/sc2json.py 
Fixed type - Committed suggestion from PR review #118

Co-authored-by: Christian Clauss <[email protected]>
  • Loading branch information
@rohits47 @cclauss
rohits47 and cclauss authored Jul 8, 2020
commit 54b0cc163b42f2396f8cdd2d5d7c45692d273005
7 changes: 6 additions & 1 deletion sc2reader/scripts/sc2json.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,12 @@ def main():
args = parser.parse_args()

factory = sc2reader.factories.SC2Factory()
factory.register_plugin("Replay", toJSON(indent=args.indent))
try:
factory.register_plugin(
"Replay", toJSON(encoding=args.encoding, indent=args.indent)
) # legacy Python
except TypeError:
factory.register_plugin("Replay", toJSON(indent=args.indent))
replay_json = factory.load_replay(args.path[0])
print(replay_json)

Expand Down