Add support for protocol 77379 (v4.11.0) #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cclauss
suggested changes
Nov 27, 2019
sc2reader/data/attributes.json
Outdated
Collaborator
There was a problem hiding this comment.
Please keep this list in sorted order because it make it easier to spot duplicates.
sc2reader/readers.py
Outdated
Collaborator
There was a problem hiding this comment.
A double ternary if is not really Pythonic. What about:
if replay.base_build >= 77379:
read_bits = 16
elif replay.base_build >= 70154:
read_bits = 13
else:
read_bits = 9
data.read_bits(read_bits)
Contributor
Author
There was a problem hiding this comment.
It might not be Pythonic, but it's consistent with rest of the code. So I'd rather keep it as is.
Unfortunately decoding functions are already hardly readable. And if there's something to be done with it, it should be tackled in separate PR IMO.
sc2reader/readers.py
Outdated
cclauss
approved these changes
Nov 27, 2019
StoicLoofah
approved these changes
Nov 28, 2019
Collaborator
|
Thanks for doing this! Now I need to go add Mengsk support elsewhere =P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on Blizzard/s2protocol@6c80b58