Skip to content

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Nov 26, 2019

No description provided.

@StoicLoofah
Copy link
Collaborator

Can you briefly explain what the additional flake8 checks are and why you added them? I have no problem doing this but just want to make sure I understand what’s going on

@cclauss
Copy link
Collaborator Author

cclauss commented Nov 28, 2019

https://flake8.pycqa.org/en/latest/user/error-codes.html

On the flake8 test selection, this PR does not focus on "style violations" (the majority of flake8 error codes that psf/black can autocorrect). Instead these tests are focus on runtime safety and correctness:

  • E9 tests are about Python syntax errors usually raised because flake8 can not build an Abstract Syntax Tree (AST). Often these issues are a sign of unused code or code that has not been ported to Python 3. These would be compile-time errors in a compiled language but in a dynamic language like Python they result in the script halting/crashing on the user.
  • F63 tests are usually about the confusion between identity and equality in Python. Use ==/!= to compare str, bytes, and int literals is the classic case. These are areas where a == b is True but a is b is False (or vice versa). Python >= 3.8 will raise SyntaxWarnings on these instances.
  • F7 tests logic errors and syntax errors in type hints
  • F82 tests are almost always undefined names which are usually a sign of a typo, missing imports, or code that has not been ported to Python 3. These also would be compile-time errors in a compiled language but in Python a NameError is raised which will halt/crash the script on the user.

Copy link
Collaborator

@StoicLoofah StoicLoofah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of that makes sense. Thanks for the explanation

@cclauss
Copy link
Collaborator Author

cclauss commented Dec 8, 2019

Ping on this one.

@StoicLoofah StoicLoofah merged commit 1fd0b6a into ggtracker:upstream Dec 8, 2019
@StoicLoofah
Copy link
Collaborator

Whoops, thanks for the reminder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants