Workaround for missing speed in GAME_SPEED_FACTOR

[cclauss]

Fixes #101

[StoicLoofah]

Thanks for looking at this! I have to admit that I'm not really familiar with real_length, but looking at the speed factors, which can be fractional, it seems like floats can certainly exist here

sc2reader/sc2reader/constants.py

Line 51 in c019743

"LotV": {"Slower": 0.2, "Slow": 0.4, "Normal": 0.6, "Fast": 0.8, "Faster": 1.0},

[cclauss]

So you want me to default to 0.6 instead of 1?

[StoicLoofah]

Sorry for being unclear: I missed actual question in the context =P

Why did you decide to use integer division instead of regular division? I'm not really sure how real/important the fractional parts are

[cclauss]

The current code wraps the calculation in int() and this PR uses // because
all(int(a / b) == a // b for a, b in ((1, 0.6), (1, 1.2), (10, 0.6), (100, 0.6), (0.6, 1))) # -> True

[StoicLoofah]

OH! I missed that int() in the original code. You definitely did that right. Also, I think using 1.0 as the default speed is probably more correct than 0.6. So everything you initially did everything correct =P

If you revert that, I will approve and merge. Thanks (and apologies) for bearing with me!

[cclauss]

#102 (review) So you want to default to faster, not normal?

[StoicLoofah]

Yes, let's default to faster. It will at least be ocrrect for alphastar and is the de facto default these for LotV ladder, right?

[StoicLoofah]

Thanks!