Does mpyq need to be added to requirements.txt?

[cclauss]

I could not get the unittests to pass without pip install mpyq.

Is mpyq used at runtime or is it only used in the unittests?

[dsjoerg]

It's used at runtime:

sc2reader/sc2reader/resources.py

Line 253 in 155ae25

self.archive = mpyq.MPQArchive(replay_file, listfile=False)

requirements.txt is not well maintained. setup.py has different logic for which packages are needed.

[cclauss]

Should we remove requirements.txt?

[dsjoerg]

The README.rst suggest multiple installation options, including pip install sc2reader. Doesn't pip use requirements.txt? I wouldn't want to completely break pip installation for people who are doing it. I would say fix it rather than remove it.

[StoicLoofah]

Fixed in #47