All activity is displayed in top right for 1v1

[dsjoerg]

From @gravelweb on April 10, 2016 22:36

The mini-map feature is not working properly for 1v1. All activity seems to be happening at the top right, outside the boundaries of the map. This doesn't seem to be an issue in 2v2.

Copied from original issue: dsjoerg/ggtracker#19

[dsjoerg]

Whoa wow that is fascinating! I had assumed that the bug affected all game modes. The fact that it only happens in 1v1 is a massive clue and should make the bug a lot easier to fix. Thanks!

[dsjoerg]

OK, I've narrowed down the problem quite a bit (while streaming my session on twitch which has been fun :) )

The problem is that for certain maps (maybe all 1v1 maps? not sure) the coordinate system as reported by replay.map.map_info.camera_left, replay.map.map_info.camera_* is no longer the same as the coordinate system used in the camera events.

Here's a session where I determined this:

was:sc2reader david$ python
Python 2.7.9 (default, Apr  7 2015, 07:58:25) 
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import sc2reader
>>> replay = sc2reader.load_replay('/Users/David/Downloads/ggtracker_6586434.SC2Replay')
>>> replay.load_map()
>>> replay.map.map_info
<sc2reader.objects.MapInfo object at 0x101a1f310>
>>> replay.map.map_info.camera_right
134217728
>>> replay.map.map_info.camera_left
1768189509
>>> replay.map.map_info.camera_top
3489660928
>>> replay.map.map_info.camera_bottom
134245999
>>> camera_events = [e for e in replay.events if e.name == 'CameraEvent']
>>> len(camera_events)
3370
>>> camera_events[2500].x
44.25
>>> camera_events[2500].y
152.61328125

here's what a normal replay is supposed to be like:

>>> replay = sc2reader.load_replay('/Users/David/Downloads/ggtracker_6586262.SC2Replay')
yo
yo
yo
yo
yo
yo
yo
yo
yo
>>> replay.load_map()
>>> replay.map.map_info.camera_left
9
>>> replay.map.map_info.camera_right
175
>>> replay.map.map_info.camera_bottom
4
>>> replay.map.map_info.camera_top
168
>>> camera_events = [e for e in replay.events if e.name == 'CameraEvent']
>>> len(camera_events)
4828
>>> camera_events[2000].x
142.1796875

[dsjoerg]

So why are certain maps reporting really weird camera coordinates? I have no clue at the moment. Maybe there has been a change in the map data format.

In the absence of other ideas, maybe the sc2replaystats guy Anthony Martin will know. I believe he is parsing some map information as well. Also the code for SCELight is open source, András might know. And I can always ask Bliz.

[dsjoerg]

The relevant function starts at https://github.com/GraylinKim/sc2reader/blob/master/sc2reader/objects.py#L478. With Heroes of the Storm they easily could have added stuff to the map format which would throw off the reader.

[dsjoerg]

OK, asked Anthony, will post if he knows anything.

[dsjoerg]

Anthony doesnt have a way, he does it manually from the Galaxy Map Editor TT @gravelweb would you like to take a crack at it from here? Two ways to go might be 1) look at the byte stream and maybe the correct bytes are obviously sitting there at a different offset, depending on which map version it is 2) look at SCELight / SC2Gears (both of which have code available) and see if either of those parses the map and if so, how.

[dsjoerg]

Anthony reminded me of another possibility; we could take a different approach completely and use some empirical magic to make a good guess. We can use the camera events themselves to estimate the min-max range.

[dsjoerg]

From @gravelweb on April 11, 2016 16:32

@dsjoerg I'm happy to look into it. Seems like a nice way to get my feet wet here :) Thanks for the details. Will check it out this evening.

[dsjoerg]

From @gravelweb on April 18, 2016 2:25

Partial fix pushed to ggtracker/sc2reader#11. Details on what I mean by "partial":

This works well with the following maps:

• Invader LE
• Korhal Carnage
• Frozen Temple
• Ruins of Endion
• Dusk Towers

Unfortunately, I'm having issues with Prion Terraces now. The symptoms are the same, but obviously the cause isn't, since my data dump is reporting seemingly correct camera info:

02:15:05 python.1 | 2016-04-18 02:15:05 2939 WARNING 10 8 150 160

I'll continue to investigate, but if you have any ideas off the top of your head.... happy to hear them!

[dsjoerg]

ok cool! no ideas off the top of my head, basically what i do to diagnose these things is start in the client and work backward until i find bad data, and then look at the parsing code and see why its creating bad data. i'll take a look at this monday or tuesday night and see what i can figure out.

that said, if ggtracker/sc2reader#11 works on the current ladder maps at least as well as the current code, then i'm inclined to push it into production and enjoy its benefits. have you tried it on the ladder maps? (not just 1v1)

[dsjoerg]

From @gravelweb on April 18, 2016 2:34

I have tried all of the 1v1 ladder maps, since those were the ones affected... But I suppose it would be nice to verify that the other modes still work too 8)

[dsjoerg]

From @gravelweb on April 18, 2016 2:51

1v1:
Newly Fixed:

• Dusk Towers
• Frozen Temple
• Ruins of Endion
• Ulrena
• Invader LE
• Korhal Carnage Knockout LE

Still Broken

• Prion Terraces

2v2:
Still Working:

• Infestation
• Omicron
• Sludge City

Newly Fixed:

• Fields of death
• Magma Mines
• Distant Plane
• Moebius Facility XX-1

3v3:
Not tested:

• Avalon Labs
• Backcountry
• Doraelus Hills
• Ice Cliffs
• New Richmond
• New Williamsberg
• Slaying Field

4v4:
Not tested:

• Abandoned Parish
• Asper Mountain
• Hidden Caves
• Kimeran Refuge
• Moebius Facility XX-1
• Research Site JD-2
• Void Zone

[dsjoerg]

From @gravelweb on April 18, 2016 2:53

Looks pretty good :) I wanted to note, however, that this feature seems to break when reaching a certain part of the replay. I'm not sure if this is related to #16

[dsjoerg]

From @gravelweb on April 18, 2016 2:55

The above reported issue is likely related to the timescale changes, as they do not seem to exist in production.

[dsjoerg]

From @gravelweb on April 18, 2016 3:1

One more thing. The existing replays don't seem to get reparsed, so this fix will not affect existing replays, unless the user re-uploads them. Is that standard in ggtracker?