Skip to content

[pull] master from webtorrent:master #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pull merged 4 commits into from
Apr 13, 2021
Merged

[pull] master from webtorrent:master #12

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce8ea41
Lower the max number of WebRTC peers in an announce to 5
feross Apr 12, 2021
dd02cdd
ensure that 'peer' is emitted before 'connect' event fires
feross Apr 12, 2021
77d409a
9.17.0
feross Apr 12, 2021
2a12b75
package metadata
feross Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ensure that 'peer' is emitted before 'connect' event fires 
This is just a defensive code change to ensure that if signal() were somehow able to cause the peer to synchronously emit the 'connect' event that we won't cause the 'error' listener to be unregistered before 'peer' is emitted and the user has a chance to register their own 'error' listener
  • Loading branch information
@feross
feross committed Apr 12, 2021
commit dd02cddcb80e52d920f8ac889bbfc957020d3ab9
4 changes: 2 additions & 2 deletions lib/client/websocket-tracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,17 +278,17 @@ class WebSocketTracker extends Tracker {
if (this._trackerId) params.trackerid = this._trackerId
this._send(params)
})
peer.signal(data.offer)
this.client.emit('peer', peer)
peer.signal(data.offer)
}

if (data.answer && data.peer_id) {
const offerId = common.binaryToHex(data.offer_id)
peer = this.peers[offerId]
if (peer) {
peer.id = common.binaryToHex(data.peer_id)
peer.signal(data.answer)
this.client.emit('peer', peer)
peer.signal(data.answer)

clearTimeout(peer.trackerTimeout)
peer.trackerTimeout = null
Expand Down