Display base completion and saturation times on LotV time-scale.

[nickelsen]

Aligns base completion and saturation times with other charts and in-game time. Only visual changes.

Prod:

Dev on this branch for same replay:

It seems there's still a measurement problem for base completion time, see ggtracker/ggtrackerstack#53 for more info. In this replay, it seems the completion times for keys is shifted by one, so time for 2nd base completed is actually when 3rd base completed and so on.

[dsjoerg]

Are all times on the site now on LotV time-scale after this change? Including but not limited to http://ggtracker.com/spending_skill_stats#?race=protoss&gateway=am, http://ggtracker.com/economy_stats#?race=protoss&vs_race=zerg and http://ggtracker.com/econ_staircase#?race=protoss&vs_race=zerg

Sorry to be so lazy :\

[nickelsen]

Ah, yes, you're right, I should include a rescaling of time on economy stats pages; economy_stats and econ_staircase.

I deliberately didn't touch anything related to spending quotient based on your comment.

Do you think we can rescale the time for the spending quotient without following through in the rest of the system? If so, I'd be happy to include that as well.

[dsjoerg]

All I meant to suggest re SQ was that the x-axis of this page: http://ggtracker.com/spending_skill_stats#?race=protoss&gateway=am should be LotV time rather than HotS time (if indeed it is in HotS time).

[nickelsen]

Ok, sure, I'll include that. I believe the graphs is still on HotS since, as far as I've understood, SQ is based on unadjusted resource_collection_rate.

[dsjoerg]

So sorry to have spaced on this, I don't know how I missed it. Looking now...

[dsjoerg]

OK I remember what this is blocked on now. I didn't want to take this PR until also updating the times displayed on these pages:
http://ggtracker.com/spending_skill_stats#?race=protoss&gateway=am, http://ggtracker.com/economy_stats#?race=protoss&vs_race=zerg and http://ggtracker.com/econ_staircase#?race=protoss&vs_race=zerg

However, thinking about it now I realize that the site is already broken/inconsistent and this PR at least moves it closer to correctness. Specifically, the time benchmarks currently shown on match pages are simply wrong when compared to reality in-game. So fixing them is bringing GGTracker at least closer to correctness.

[nickelsen]

Thanks, man! And so sorry for not getting back to this one - at least with a status-update.

My mind exploded trying to understand which time-series were in which time-scales, so I never finished the updates to the pages.

Meanwhile, I also got a kid, so unfortunately - for now - priorities have shifted away from pretty much everything related to SC2 and pass-time programming.

[dsjoerg]

@nickelsen congrats on the kid! w00t w00t!