Rescale APM series to show it correctly in LotV replays. #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this._series.apm.entities[_entity] = $.extend({data: entity.data.apm, pointStart: 1}, base_series); | ||
| this._series.wpm.entities[_entity] = $.extend({data: entity.data.wpm, pointStart: 1}, base_series); | ||
| this._series.creep_spread.entities[_entity] = $.extend({data: entity.data.creep_spread, pointStart: 1}, base_series); | ||
| console.log(entity.data.apm); |
There was a problem hiding this comment.
of course you want to remove this
There was a problem hiding this comment.
Yes, good catch! I've updated the commit.
nickelsen
force-pushed
the
rescale-apm-series
branch
from
68662b6 to
be09707
Compare
|
Should I do more on this or do you want to merge it as is? |
|
I will test it and see if it's OK to deploy. There are no outstanding issues aside from my need to test it. |
|
Looks good! Tried it on a 1v1 and a 2v2 and it worked on both :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I bailed on fixing apm from the ground up and gave it a shot at 'just' fixing the plotting. This seem to work.
I've tested it by comparing a replay (from tonight) between my ggtrackerstack and ggtracker.com, which are pretty similar (although it seems to have had a positive effect on creep spread tracking visualization also).
ggtrackerstack:
ggtracker.com:
