Display units in comparison graph for 1v1 AI#15
Merged
dsjoerg merged 2 commits intodsjoerg:masterfrom Aug 3, 2015
Merged
Conversation
Reduce noise in code coverage output. All spec files are run 100% in the test suite. This lowers the overall code coverage number...sorry :D
Contributor
Author
|
Adapting this change to non 1v1 games might be similar. The AI names have an index, i.e. |
dsjoerg
added a commit
that referenced
this pull request
Aug 3, 2015
Display units in comparison graph for 1v1 AI
Owner
|
Looks good Eric! The JS test suite never worked, the guy who put it in never got it working properly, probably the best thing to do at this point would be to remove it. Do you want to add more vs-AI related functionality before I push this into production? Or is this ready to go? |
Contributor
Author
|
Ah, understood. This is a good time to push. I haven't looked into what it'll take to get the charts displaying for vs-AI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to run the JS test suite, but Testacular has been renamed to Karma, and Karma didn't run with the base
testacular.conf.jsfile out of the box from npm. Complaining with: