Skip to content

Commit 6a4c1b2

Browse files
[Bug] Fix Skipped Tests not marked as skipped (alexjustesen#1818)
Fix db colunm and cancel job Co-authored-by: Alex Justesen <[email protected]>
1 parent 04dbee3 commit 6a4c1b2

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

app/Jobs/Ookla/CompleteSpeedtestJob.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ public function __construct(
2525
*/
2626
public function handle(): void
2727
{
28+
if ($this->batch()->cancelled()) {
29+
return;
30+
}
31+
2832
$this->result->update([
2933
'status' => ResultStatus::Completed,
3034
]);

app/Jobs/SkipSpeedtestJob.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function handle(): void
5252
'data->type' => 'log',
5353
'data->level' => 'error',
5454
'data->message' => $shouldSkip,
55-
'interface->externalIp' => $externalIp,
55+
'data->interface->externalIp' => $externalIp,
5656
'status' => ResultStatus::Skipped,
5757
]);
5858

0 commit comments

Comments
 (0)