Skip to content

[Bug] Fix Skipped Tests not marked as skipped #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexjustesen merged 2 commits into from
Nov 23, 2024
Merged

[Bug] Fix Skipped Tests not marked as skipped #1818

alexjustesen merged 2 commits into from
Nov 23, 2024

Conversation

@svenvg93
Copy link
Contributor

@svenvg93 svenvg93 commented Nov 23, 2024 •
edited
Loading

📃 Description

This PR fixes writing the skipped tests are not marked as skipped

🪵 Changelog

🔧 Fixed

  • Set the correct db schema for saving the IP 'data->interface->externalIp' instead of interface->externalIp' => $externalIp
  • CompletedSpeedtestJob ignored cancelled jobs which got them marks as completed instead of skipped

@svenvg93 svenvg93 changed the title [Bug] Fix Skipped IP not working properly [Bug] Fix Skipped IP not marked as skipped Nov 23, 2024
@svenvg93 svenvg93 changed the title [Bug] Fix Skipped IP not marked as skipped [Bug] Fix Skipped Tests not marked as skipped Nov 23, 2024
@alexjustesen alexjustesen merged commit 6a4c1b2 into alexjustesen:main Nov 23, 2024
@svenvg93 svenvg93 deleted the bug/fix-ip-skipped branch November 23, 2024 21:50
@svenvg93 svenvg93 mentioned this pull request Nov 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexjustesen alexjustesen alexjustesen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@svenvg93 @alexjustesen