Skip to content

templates/rebase: general updates#2135

Merged
marmijo merged 3 commits into
coreos:mainfrom
marmijo:rebase-checklist-updates
May 14, 2026
Merged

templates/rebase: general updates#2135
marmijo merged 3 commits into
coreos:mainfrom
marmijo:rebase-checklist-updates

Conversation

@marmijo
Copy link
Copy Markdown
Member

@marmijo marmijo commented Apr 14, 2026

See individual commits

@marmijo marmijo changed the title rebase: update steps to untag old packages templates/rebase: update steps to untag old packages Apr 14, 2026
@marmijo marmijo force-pushed the rebase-checklist-updates branch from 57841c4 to c085f5a Compare April 14, 2026 23:19
Comment thread .github/ISSUE_TEMPLATE/rebase.md Outdated
If there are any RPMs signed by the old key they'll need to be investigated. Maybe they shouldn't be used any longer. Or maybe they're still needed. One example of this is the shim RPM where the same build could be used for many Fedora releases. In this case you'll need to untag the RPM from `coreos-pool`, run a `koji distrepo`, which will remove that RPM from the repo metadata, and then re-tag it into the pool. The RPM in the repo will now be signed with a newer signing key.
If there are any packages in the output, there are two possible cases:

1. **The package is signed by multiple keys** including an older one. This is OK, but add it to the untaglist anyway so it gets retagged into `coreos-pool` with a newer key/signature. You'll need to untag the RPM from `coreos-pool`, run a `koji distrepo` (which will remove that RPM from the repo metadata), and then re-tag it into the pool. The RPM in the repo will now be signed with a newer signing key.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should give the full distrepo command:

Suggested change
1. **The package is signed by multiple keys** including an older one. This is OK, but add it to the untaglist anyway so it gets retagged into `coreos-pool` with a newer key/signature. You'll need to untag the RPM from `coreos-pool`, run a `koji distrepo` (which will remove that RPM from the repo metadata), and then re-tag it into the pool. The RPM in the repo will now be signed with a newer signing key.
1. **The package is signed by multiple keys** including an older one. This is OK, but add it to the untaglist anyway so it gets retagged into `coreos-pool` with a newer key/signature. You'll need to untag the RPM from `coreos-pool`, run a `koji dist-repo --non-latest coreos-pool key1 key2 key3` (which will remove that RPM from the repo metadata), and then re-tag it into the pool. The RPM in the repo will now be signed with a newer signing key.

Copy link
Copy Markdown
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM - a few comments.

Also, let's update all links to the ansible repo to point to the new source of truth: https://forge.fedoraproject.org/infra/ansible.git

@marmijo marmijo changed the title templates/rebase: update steps to untag old packages templates/rebase: general updates May 8, 2026
@marmijo marmijo force-pushed the rebase-checklist-updates branch from c085f5a to 26dbb2e Compare May 8, 2026 19:49
Copy link
Copy Markdown
Member

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marmijo marmijo merged commit e0cbcdc into coreos:main May 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants