Skip to content

Conversation

@nethew
Copy link
Contributor

@nethew nethew commented Oct 23, 2017

Solves too wide title column like in the case of https://www.pathofexile.com/forum/view-post/14987094
Also makes the title always on one line - nowrap, which keeps the line height always the same. You can reconsider this if you want to.

Solves too wide title column like in the case of https://www.pathofexile.com/forum/view-post/14987094
Also makes the title always on one line - nowrap, which keeps the line height always the same. You can reconsider this if you want to.
@ccbrown
Copy link
Owner

ccbrown commented Oct 30, 2017

Sorry for the delay. I'll do my best to review this today. Thanks!

@ccbrown ccbrown merged commit 7645e67 into ccbrown:master Nov 1, 2017
@ccbrown
Copy link
Owner

ccbrown commented Nov 1, 2017

Thanks for the PR!

I did go ahead and remove the nowrap for now. If we restricted rows to one line, I would definitely want some way of seeing the entire thing. Maybe either by shrinking the text or showing a tooltip on hover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants