Skip to content

GraphQL Domains Resolvers - #99

Merged
nsdeschenes merged 1 commit into
masterfrom
graphql-domains-resolvers
Feb 14, 2020
Merged

GraphQL Domains Resolvers#99
nsdeschenes merged 1 commit into
masterfrom
graphql-domains-resolvers

Conversation

@nsdeschenes

Copy link
Copy Markdown
Contributor
  • Completed initial resolvers for domains
  • Created test for initial domain resvolers
  • Added domain resovlers into queries.py
  • Fixed styling issues in url.py, and added new REGEX to find help reduce incorrect input
  • Fixed styling issues in email_address.py

- Created test for initial domain resvolers
- Added domain resovlers into queries.py
- Fixed styling issues in url.py, and added new REGEX to find help reduce incorrect input
- Fixed styling issues in email_address.py
@nsdeschenes
nsdeschenes requested a review from peacheym February 14, 2020 14:58

@peacheym peacheym left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Only thing I request is the error messages as functions once again. Good to keep that consistent!

@nsdeschenes
nsdeschenes merged commit d208174 into master Feb 14, 2020
@nsdeschenes
nsdeschenes deleted the graphql-domains-resolvers branch February 14, 2020 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants