Skip to content

fix(dns-scanner): extended CNAME/NS results - #7442

Open
lcampbell2 wants to merge 7 commits into
masterfrom
fix/split-dns-query-scanner-results
Open

fix(dns-scanner): extended CNAME/NS results#7442
lcampbell2 wants to merge 7 commits into
masterfrom
fix/split-dns-query-scanner-results

Conversation

@lcampbell2

@lcampbell2 lcampbell2 commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator
  • Updated dns_scanner.py to:

    • include CNAME in the record_exists gate (alongside A, SOA, NS),
    • preserve/derive rcode from multiple query attempts more reliably,
    • add new result fields:
      • ns_delegations
      • registrar_context
    • call new helper functions for NS delegation checks and RDAP registrar context.
  • Added new module ns_registrar.py with:

    • check_ns_delegations(...)
      • resolves NS hosts,
      • probes authoritative SOA responses directly against nameserver IPs,
      • classifies delegation health as none / partial / full lame delegation.
    • get_registrar_context(...)
      • performs RDAP lookup via https://rdap.org/domain/<domain>,
      • extracts registrar metadata and RDAP nameservers,
      • compares observed delegation NS hosts with RDAP NS data.

@lcampbell2
lcampbell2 requested a review from FestiveKyle July 7, 2026 20:41
@lcampbell2 lcampbell2 changed the title Fix: extended CNAME/NS results fix(dns-scanner): extended CNAME/NS results Jul 7, 2026
Comment thread scanners/dns-scanner/dns_scanner/ns_registrar.py Outdated
Comment thread scanners/dns-scanner/dns_scanner/ns_registrar.py Outdated
Comment thread scanners/dns-scanner/dns_scanner/dns_scanner.py Outdated
return ns_ip


def check_ns_delegations(domain, zone_apex, ns_records, resolver=None, timeout_sec=10):

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble getting this to flag a real lame nameserver, do you have a working domain I can test it against?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants