Refactoring Old API Stuff - #581
Merged
Merged
Conversation
nsdeschenes
requested review from
Ethanljf,
lcampbell2,
sleepycat and
tparrott-cse
June 24, 2020 14:52
Ethanljf
approved these changes
Jun 24, 2020
Ethanljf
left a comment
Ethanljf
left a comment
Contributor
There was a problem hiding this comment.
Awesome resolvers 🔥 Great stuff
lcampbell2
approved these changes
Jun 25, 2020
added 18 commits
June 25, 2020 13:26
…refactor findOrganizationDetailBySlug resolver to use correct schema, update files that use organizations schema
…etailsBySlug name to match schema directory, and corrected name for org model tests
nsdeschenes
force-pushed
the
refactoring-old-api-stuff
branch
from
June 25, 2020 16:26
fe091c5 to
1421aec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So this kinda snowballed into a bigger PR then I was hoping for, however these changes should really bring the api forward. I will be re-working the notification email stuff in a future PR is there is a lot of work to do there and get it to where I want it. But for now, domains, and organizations have been split into their own different queries with meaningful names, and will hopefully bring some clarity to the front end guys who need to use them. Everything has tests, and everything has been ran through black as well.