Skip to content

Graph ql creating initial scalars - #54

Merged
nsdeschenes merged 5 commits into
masterfrom
GraphQL-creating-initial-scalars
Jan 30, 2020
Merged

Graph ql creating initial scalars#54
nsdeschenes merged 5 commits into
masterfrom
GraphQL-creating-initial-scalars

Conversation

@nsdeschenes

Copy link
Copy Markdown
Contributor

Also added in a new regex

@nsdeschenes
nsdeschenes requested a review from peacheym January 30, 2020 13:10

@peacheym peacheym left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting requests made. Actual code functionality looks good!

Comment thread api/tests/test_email_address_scalar.py Outdated
Comment thread api/tests/test_email_address_scalar.py Outdated

@peacheym peacheym left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the update!

@nsdeschenes
nsdeschenes merged commit ab677f0 into master Jan 30, 2020
@nsdeschenes
nsdeschenes deleted the GraphQL-creating-initial-scalars branch January 30, 2020 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants