Skip to content

Finally Fixing Up the Guidance Tags#522

Merged
nsdeschenes merged 39 commits into
masterfrom
finally-fixing-up-the-guidance-tags
Jun 11, 2020
Merged

Finally Fixing Up the Guidance Tags#522
nsdeschenes merged 39 commits into
masterfrom
finally-fixing-up-the-guidance-tags

Conversation

@nsdeschenes

Copy link
Copy Markdown
Contributor

Alrighty its finally time for the first real iteration of the guidance tags. Will probably need some overhauling once we get more real data into the system.

  • Guidance tags for DKIM, DMARC, SPF, HTTPS, and SSL
  • Tests for all guidance tag expected possibilities
  • Black ran on all modified files
  • Minor changes and fixes

This is an example of the current base implementation for testing, please write new query that suite the purposes of the page you are working on.

{
    domain(urlSlug: "test-domain-ca") {
        url
        email {
            edges {
                node {
                    dkim {
                        record
                        keyLength
                        dkimGuidanceTags
                    }
                    dmarc {
                        record
                        pPolicy
                        spPolicy
                        pct
                        dmarcGuidanceTags
                    }
                    spf {
                        lookups
                        record
                        spfDefault
                        spfGuidanceTags
                    }
                }
            }
        }
        www {
            edges {
                node {
                    https {
                        implementation
                        enforced
                        hsts
                        hstsAge
                        preloaded
                        httpsGuidanceTags
                    }
                    ssl {
                        sslGuidanceTags
                    }
                }
            }
        }
    }
}

@nsdeschenes
nsdeschenes force-pushed the finally-fixing-up-the-guidance-tags branch from dd51e04 to 4829495 Compare June 9, 2020 17:15

@tparrott-cse tparrott-cse left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nsdeschenes
nsdeschenes force-pushed the finally-fixing-up-the-guidance-tags branch from 4829495 to 19ae93f Compare June 11, 2020 09:52
@nsdeschenes
nsdeschenes merged commit 904a997 into master Jun 11, 2020
@nsdeschenes
nsdeschenes deleted the finally-fixing-up-the-guidance-tags branch June 11, 2020 09:58

@sleepycat sleepycat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants