Finally Fixing Up the Guidance Tags#522
Merged
Merged
Conversation
nsdeschenes
force-pushed
the
finally-fixing-up-the-guidance-tags
branch
from
June 9, 2020 17:15
dd51e04 to
4829495
Compare
Ethanljf
approved these changes
Jun 10, 2020
added 24 commits
June 11, 2020 06:52
added 15 commits
June 11, 2020 06:52
nsdeschenes
force-pushed
the
finally-fixing-up-the-guidance-tags
branch
from
June 11, 2020 09:52
4829495 to
19ae93f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alrighty its finally time for the first real iteration of the guidance tags. Will probably need some overhauling once we get more real data into the system.
This is an example of the current base implementation for testing, please write new query that suite the purposes of the page you are working on.
{ domain(urlSlug: "test-domain-ca") { url email { edges { node { dkim { record keyLength dkimGuidanceTags } dmarc { record pPolicy spPolicy pct dmarcGuidanceTags } spf { lookups record spfDefault spfGuidanceTags } } } } www { edges { node { https { implementation enforced hsts hstsAge preloaded httpsGuidanceTags } ssl { sslGuidanceTags } } } } } }