Add Summary Charts to Landing Page#519
Merged
Merged
Conversation
lcampbell2
commented
Jun 8, 2020
lcampbell2
commented
Collaborator
- Add summary donuts to landing page and fill them with mocked data
- Create domain summary table component
create domain summary table
lcampbell2
requested review from
Ethanljf,
FestiveKyle,
nsdeschenes,
sleepycat and
tparrott-cse
FestiveKyle
approved these changes
Jun 8, 2020
This commit reigns in the number of doughnuts on the landing page and slims down the code as well. The nav bar has also been changed to match the title bar in the doughnut box, and the green used for the "pass" color has been lightened: both of these changes are being done to reach a better colour contrast for low vision users.
This commit updates the test data for the DomainsPage that had fallen out of sync with the query. This resolves some warnings that were displayed when the tests ran.
sleepycat
approved these changes
Jun 9, 2020
sleepycat
left a comment
sleepycat
left a comment
Contributor
There was a problem hiding this comment.
I polished this up a little. Let's get this in so we can get some feedback on it.
| Indicates the preferred language of this user | ||
| """ | ||
| lang: String @examples(values: ["English", "French"]) | ||
| lang: String @examples(values: ["ENGLSIH", "FRENCH"]) |
Contributor
There was a problem hiding this comment.
I think you meant ENGLISH. 😺
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.