Skip to content

Optimize domain connections by user id loader#4575

Merged
FestiveKyle merged 2 commits into
masterfrom
load-user-domains-faster
Jun 7, 2023
Merged

Optimize domain connections by user id loader#4575
FestiveKyle merged 2 commits into
masterfrom
load-user-domains-faster

Conversation

@FestiveKyle

Copy link
Copy Markdown
Collaborator

Remove extra loop through domains. This adjustment should reduce loading time for the domains page (no login required) from ~4.3s to ~2.0s.

Effort for #4573

@FestiveKyle
FestiveKyle requested a review from lcampbell2 June 6, 2023 20:36

@lcampbell2 lcampbell2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡ ⚡ ⚡

@FestiveKyle
FestiveKyle merged commit 91db267 into master Jun 7, 2023
@FestiveKyle
FestiveKyle deleted the load-user-domains-faster branch June 7, 2023 18:41
@FestiveKyle

Copy link
Copy Markdown
Collaborator Author

Old/new timings from prod:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants