Skip to content

Update connection chain results display #4530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcampbell2 merged 1 commit into from
May 17, 2023
Merged

Update connection chain results display #4530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions frontend/src/guidance/WebConnectionResults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,19 @@ export function WebConnectionResults({ connectionResults }) {
<DetailTooltip
label={t`Shows if the HTTP endpoint upgrades to HTTPS upgrade immediately, eventually (after the first redirect), or never.`}
>
<StatusIcon status={httpImmediatelyUpgrades ? 'PASS' : 'FAIL'} />
<StatusIcon status={!httpLive ? 'INFO' : httpImmediatelyUpgrades ? 'PASS' : 'FAIL'} />
<Text px="1">
<Trans>HTTP Upgrades</Trans>
</Text>
</DetailTooltip>
<Text>
{httpImmediatelyUpgrades ? t`Immediately` : httpEventuallyUpgrades ? t`Eventually` : t`Never`}
{!httpLive
? t`Not available`
: httpImmediatelyUpgrades
? t`Immediately`
: httpEventuallyUpgrades
? t`Eventually`
: t`Never`}
</Text>
</Flex>
</Box>
Expand Down Expand Up @@ -194,7 +200,7 @@ export function WebConnectionResults({ connectionResults }) {
<Trans>HSTS Max Age</Trans>
</Text>
</DetailTooltip>
<Text>{hstsParsed?.maxAge}</Text>
<Text>{hstsParsed?.maxAge || t`Not available`}</Text>
</Flex>
<Flex {...columnInfoStyleProps}>
<DetailTooltip label={t`Shows if the HSTS header includes the preload directive.`}>
Expand All @@ -203,7 +209,7 @@ export function WebConnectionResults({ connectionResults }) {
<Trans>HSTS Preloaded</Trans>
</Text>
</DetailTooltip>
<Text>{hstsParsed?.preload ? t`Yes` : t`No`}</Text>
<Text>{!hstsParsed ? t`Not available` : hstsParsed?.preload ? t`Yes` : t`No`}</Text>
</Flex>
<Flex {...columnInfoStyleProps}>
<DetailTooltip label={t`Shows if the HSTS header includes the includeSubdomains directive.`}>
Expand All @@ -212,7 +218,7 @@ export function WebConnectionResults({ connectionResults }) {
<Trans>HSTS Includes Subdomains</Trans>
</Text>
</DetailTooltip>
<Text>{hstsParsed?.includeSubdomains ? t`Yes` : t`No`}</Text>
<Text>{!hstsParsed ? t`Not available` : hstsParsed?.includeSubdomains ? t`Yes` : t`No`}</Text>
</Flex>
</Box>
<Text mt="2" fontWeight="bold" mx="2">
Expand Down