No sidecar for domain-dispatcher job#3708
Closed
sleepycat wants to merge 1 commit into
Closed
Conversation
This commit adds an injection to the domain-dispatcher job that prevents the istio sidecar from being injected. With sidecars injected, the jobs are not properly marked as completed, even though they are. ```bash $ kubectl get jobs -n scanners domain-dispatcher-27551520 NAME COMPLETIONS DURATION AGE domain-dispatcher-27551520 0/1 20h 20h ```
FestiveKyle
self-requested a review
May 26, 2022 17:39
FestiveKyle
approved these changes
May 26, 2022
Contributor
Author
|
Closed in favour of #3741 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds an injection to the domain-dispatcher job that prevents the
istio sidecar from being injected.
With sidecars injected, the jobs are not properly marked as completed, even
though they are.
$ kubectl get jobs -n scanners domain-dispatcher-27551520 NAME COMPLETIONS DURATION AGE domain-dispatcher-27551520 0/1 20h 20h