Fix lingui plural warning - #293
Merged
Merged
Conversation
This commit started with fixing a warning about plurals not working when the app was loaded. Fixing that caused some breakage in the tests. Fixing that revealed that none of the funkyness that broke was needed in the first place so I'm ripping that out. The result is everything is much cleaner and there are no warnings to be found anywhere!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit started with fixing a warning about plurals not working when the
app was loaded. Fixing that caused some breakage in the tests. Fixing that
revealed that none of the funkyness that broke was needed in the first place so
I'm ripping that out.
The result is everything is much cleaner and there are no warnings to be found
anywhere!