DMARC not consistently denoted by failures#2374
Merged
EveningStarlight merged 5 commits intoJun 8, 2021
Merged
Conversation
Most locations marked what control failed, But the DMARC graphs marked which control passed All locations now go by the failure to be consistent.
FestiveKyle
requested changes
Jun 7, 2021
FestiveKyle
left a comment
FestiveKyle
left a comment
Collaborator
There was a problem hiding this comment.
Translations need to be updated in the locales/*.po files. Default translation entries can be generated in these files by running npm run extract as long as the text to be translated exists inside either a <Trans /> tag or t``
FestiveKyle
requested changes
Jun 7, 2021
Comment on lines
-214
to
+221
| name: 'passSpfOnly', | ||
| displayName: t`Pass Only SPF`, | ||
| name: 'failDkim', | ||
| displayName: t`Fail DKIM`, | ||
| }, | ||
| ], | ||
| moderateAlt: [ | ||
| { | ||
| name: 'passDkimOnly', | ||
| displayName: t`Pass Only DKIM`, | ||
| name: 'failSpf', | ||
| displayName: t`Fail SPF`, |
Collaborator
There was a problem hiding this comment.
These fields need their 'name' properties to stay 'passSpfOnly' and 'passDkimOnly'. These names come from the API. The display names are good though!
# Conflicts: # frontend/src/locales/en.po # frontend/src/locales/fr.po
Collaborator
|
I fixed the merge conflict here. The locales make for some annoying conflicts sometimes, it wasn't bad this time though |
Contributor
Author
|
Thanks, I appreciate it. |
EveningStarlight
deleted the
UX-DMARC-not-consistently-denoted-by-failures
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most locations marked what control failed,
But the DMARC graphs marked which control passed
All locations now go by the failure to be consistent.