Add titles to pages#1980
Merged
Merged
Conversation
…add-titles-to-pages # Conflicts: # frontend/src/App.js # frontend/src/DmarcGuidancePage.js # frontend/src/Page.js
tparrott-cse
approved these changes
Mar 29, 2021
Contributor
Author
|
Dynamic titles are fixed thanks to @FestiveKyle! |
ThomasNickerson
requested review from
FestiveKyle and
lcampbell2
and removed request for
sleepycat
lcampbell2
approved these changes
Mar 29, 2021
FestiveKyle
approved these changes
Mar 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds descriptive titles to all pages.
Code for dynamic titles where appropriate is included but commented out due to a bug causing titles to sometimes read "undefined". This will be implemented as soon as a fix is found.