Skip to content

Refactoring Error Messages for the API#1852

Merged
nsdeschenes merged 21 commits into
masterfrom
api-refactoring-error-messages
Mar 16, 2021
Merged

Refactoring Error Messages for the API#1852
nsdeschenes merged 21 commits into
masterfrom
api-refactoring-error-messages

Conversation

@nsdeschenes

Copy link
Copy Markdown
Contributor

As described.

@Ethanljf Ethanljf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments! Looks great otherwise!

Comment thread api-js/src/affiliation/mutations/__tests__/update-user-role.test.js Outdated
Comment thread api-js/src/affiliation/mutations/__tests__/update-user-role.test.js Outdated
Comment thread api-js/src/affiliation/mutations/__tests__/update-user-role.test.js Outdated
Comment thread api-js/src/affiliation/mutations/update-user-role.js Outdated
Comment thread api-js/src/affiliation/mutations/update-user-role.js Outdated
Comment thread api-js/src/affiliation/mutations/update-user-role.js Outdated
Comment thread api-js/src/affiliation/mutations/update-user-role.js Outdated
Comment thread api-js/src/affiliation/mutations/update-user-role.js Outdated
Comment thread api-js/src/affiliation/mutations/update-user-role.js Outdated
@nsdeschenes nsdeschenes requested a review from Ethanljf March 15, 2021 09:55
@nsdeschenes nsdeschenes force-pushed the api-refactoring-error-messages branch from 1579b62 to 0e993f7 Compare March 15, 2021 14:00
@nsdeschenes nsdeschenes merged commit 2bd18d5 into master Mar 16, 2021
@nsdeschenes nsdeschenes deleted the api-refactoring-error-messages branch March 16, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants