Graphql Schema Introduction#155
Merged
Merged
Conversation
nsdeschenes
requested review from
Ethanljf,
peacheym,
sleepycat and
tparrott-cse
March 10, 2020 11:53
peacheym
suggested changes
Mar 10, 2020
peacheym
left a comment
peacheym
left a comment
Contributor
There was a problem hiding this comment.
Nice work my man! I had a few questions but only about clean code format and some of the error messages! This was a huge PR though!!
Ethanljf
approved these changes
Mar 10, 2020
Ethanljf
left a comment
Ethanljf
left a comment
Contributor
There was a problem hiding this comment.
Syntactically sound (Assuming 'none' is a valid value within the API functions). Great work on the docs! :)
tparrott-cse
approved these changes
Mar 10, 2020
nsdeschenes
force-pushed
the
graphql-schema-introduction
branch
from
March 10, 2020 16:57
9e52c7f to
a678269
Compare
added 21 commits
March 10, 2020 14:06
Fixing formatting
…and commented them out from the schema. Waiting on db decision
Added in .all() in missing cases
…arc and spf scans results be returned
… into seperate files in the functions folder
… dkim tag generation
added 9 commits
March 10, 2020 14:06
nsdeschenes
force-pushed
the
graphql-schema-introduction
branch
from
March 10, 2020 17:06
a678269 to
12bd3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is quite a big shift for the API, the schema has been started from scratch (minus the user related stuff). Scans, and scan tags are not yet completed, but I would like to separate those into their own PR's rather than continuing in this one and create a massive PR.