Initial depth check setup, testing has also been completed - #141
Merged
Conversation
nsdeschenes
requested review from
Ethanljf,
peacheym,
sleepycat and
tparrott-cse
February 28, 2020 14:28
sleepycat
suggested changes
Feb 28, 2020
sleepycat
left a comment
sleepycat
left a comment
Contributor
There was a problem hiding this comment.
A few suggestions, but some great stuff in here!
nsdeschenes
force-pushed
the
graphql-cycle-security-check
branch
from
March 2, 2020 11:20
2d138fc to
54c8b2d
Compare
Contributor
Author
|
Also added in a default value of 10, this should make it easier to change and customize depending on usage. |
Contributor
Author
|
Hold off on review, I think I have something good to add in |
Contributor
Author
|
New Changes
|
added 2 commits
March 3, 2020 07:32
peacheym
approved these changes
Mar 3, 2020
peacheym
left a comment
peacheym
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Good to have the depth check to make sure we don't get a huge (& slow) API call! :)
sleepycat
approved these changes
Mar 3, 2020
|
|
||
| db.init_app(app) | ||
|
|
||
| backend = SecurityAnalysisBackend(max_depth=10, max_cost=1000) |
Ethanljf
approved these changes
Mar 3, 2020
Ethanljf
left a comment
Ethanljf
left a comment
Contributor
There was a problem hiding this comment.
Syntactically sound. Great stuff!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will bring in a new security check that will not all users to submit a query of depth 10 or greater. The depth can be changed at any time inside the
api/backend/depth_check.pyfile.