Skip to content

Implementation of user-affiliation loaders and tests#1113

Merged
Ethanljf merged 3 commits into
masterfrom
user-affiliations-js-api
Nov 4, 2020
Merged

Implementation of user-affiliation loaders and tests#1113
Ethanljf merged 3 commits into
masterfrom
user-affiliations-js-api

Conversation

@Ethanljf

@Ethanljf Ethanljf commented Nov 3, 2020

Copy link
Copy Markdown
Contributor

Brings user-affiliation loaders to the upcoming JS API

@Ethanljf Ethanljf requested a review from nsdeschenes November 3, 2020 12:52

@nsdeschenes nsdeschenes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect minus these slight changes needed! 😀

Comment thread api-js/src/loaders/user-affiliations/load-user-affiliations-by-org-id.js Outdated
Comment thread api-js/src/loaders/user-affiliations/load-user-affiliations-by-org-id.js Outdated
Comment thread api-js/src/loaders/user-affiliations/load-user-affiliations-by-user-id.js Outdated
Comment thread api-js/src/loaders/user-affiliations/load-user-affiliations-by-user-id.js Outdated
@nsdeschenes nsdeschenes self-requested a review November 4, 2020 12:26
@Ethanljf Ethanljf merged commit bb5fe25 into master Nov 4, 2020
@Ethanljf Ethanljf deleted the user-affiliations-js-api branch November 4, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants