Skip to content

V2.4.2 fix backlog entry #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2024
Merged

V2.4.2 fix backlog entry #52

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24ecd82
v2.4.2 fix backlog entry
brucewzj99 May 14, 2024
0143b89
fix typo
brucewzj99 May 14, 2024
80fecd4
cleaner code
brucewzj99 May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo
  • Loading branch information
@brucewzj99
brucewzj99 committed May 14, 2024
commit 0143b894182424eec94ec2cf77f0b7bb1658e980
17 changes: 8 additions & 9 deletions bot/google_sheet_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,14 +237,13 @@ def move_row_down(spreadsheet_id, sheet_id, first_row_to_move, last_row_to_move)
def create_backlog_entry(spreadsheet_id, backlog_day, backlog_month, row_data):
backlog_month = backlog_month.title()
try:
try:
day_first_entry_index = get_day_first_entry_index(
spreadsheet_id, backlog_month, backlog_day
)
first_row_to_move = int(get_first_row_to_move(spreadsheet_id, backlog_month, backlog_day))
last_row_to_move = int(get_last_entered_row(spreadsheet_id, backlog_month))
new_entry_row = first_row_to_move
sheet_id = get_sheet_id_by_title(spreadsheet_id, backlog_month.title())
day_first_entry_index = get_day_first_entry_index(
spreadsheet_id, backlog_month, backlog_day
)
first_row_to_move = int(get_first_row_to_move(spreadsheet_id, backlog_month, backlog_day))
last_row_to_move = int(get_last_entered_row(spreadsheet_id, backlog_month))
new_entry_row = first_row_to_move
sheet_id = get_sheet_id_by_title(spreadsheet_id, backlog_month.title())

if last_row_to_move >= first_row_to_move:
move_row_down(spreadsheet_id, sheet_id, first_row_to_move, last_row_to_move)
Expand All @@ -266,7 +265,7 @@ def create_backlog_entry(spreadsheet_id, backlog_day, backlog_month, row_data):
# datatime data
current_datetime = dt.datetime.now(timezone)
month = current_datetime.strftime("%b")

# if backlog month is current month, need to update tracker to reflect backlog changes
if backlog_month.title() == month:
if last_row_to_move < first_row_to_move and day_first_entry_index == new_entry_row:
Expand Down