Skip to content

Fix v2.1.2 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix v2.1.2 #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bot/telegram_bot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,9 @@ def set_up(update, context) -> int:
db.new_user_setup(telegram_id, sheet_id)
current_datetime = dt.datetime.now(timezone)
day = current_datetime.day
month = current_datetime.strftime("%b")
gs.update_rows(sheet_id, day, 4, 5) # New users start from row 5
gs.create_date(sheet_id, day, month, 5)
update.message.reply_text(SUCCESS_LINK_TEXT)
return ConversationHandler.END
except Exception as e:
Expand Down Expand Up @@ -544,7 +546,7 @@ def add_transport(update, context):
except Exception as e:
update.callback_query.message.reply_text(ERROR_TEXT)
return ConversationHandler.END
if setting_list is None or setting_list[0] is None:
if not setting_list or not setting_list[0]:
update.message.reply_text(QUICK_SETUP_TRANSPORT)
return ConversationHandler.END
else:
Expand All @@ -569,7 +571,7 @@ def add_others(update, context):
except Exception as e:
update.callback_query.message.reply_text(ERROR_TEXT)
return ConversationHandler.END
if setting_list is None or setting_list[0] is None:
if not setting_list or not setting_list[0]:
update.message.reply_text(QUICK_SETUP_OTHER)
return ConversationHandler.END
else:
Expand Down
7 changes: 6 additions & 1 deletion release_notes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,9 @@
## Version 2.1.1 - Date 8 Jun 2023
### Enhancement 🔥
- Migrate to use firestore
- Reformatted get overall transaction
- Reformatted get overall transaction

## Version 2.1.2 - Date 26 Jun 2023
### Bug Fix 🛠️
- When new users join, new date entry was not created
- Quick add settings not sending proper error message when either transport or others has been configured