Skip to content

Conversation

@alexjustesen
Copy link
Owner

@alexjustesen alexjustesen commented Dec 13, 2023

Description

This PR introduces a db_has_timezone setting that let's the application know the database is already reporting in the local time.

Testing

Configuration

  • TZ environment variable was not passed to the application's container.
  • Database had a TZ environment variable of America/New_York which matched the setting in the application's UI.
  • Local time was set in the Time zone setting under the "General Settings" page.
  • Database has time zone was enabled.

Results

  • The scheduler still runs at the correct time, (i.e. 7:25 PM EST).
  • The database returns 2023-12-12 19:25:xx for the 7:25 PM scheduled run.
  • "Lastest result: ..." correctly displays the time difference
  • Results table correctly displays 2023-12-12 19:25:xx
  • Charts correctly display 2023-12-12 19:25:xx

Changelog

Added

  • db_has_timezone to general settings

Changed

  • changed the layout of the general settings page

Screenshots

image
Dashboard

image
Results Screenshot

image
General Settings page

@alexjustesen alexjustesen added the feature New feature or request label Dec 13, 2023
@alexjustesen alexjustesen added this to the v0.14.0 (timezones) milestone Dec 13, 2023
@alexjustesen alexjustesen self-assigned this Dec 13, 2023
@alexjustesen alexjustesen marked this pull request as draft December 13, 2023 01:18
@alexjustesen alexjustesen marked this pull request as ready for review December 13, 2023 01:42
@alexjustesen alexjustesen merged commit 8fc5e2a into main Dec 13, 2023
@alexjustesen alexjustesen deleted the database-has-time-zone-setting branch December 13, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants