-
-
Notifications
You must be signed in to change notification settings - Fork 204
[Bug] Fix incorrectly formatted json data #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alexjustesen
merged 45 commits into
v0.16.0-dev
from
fix-incorrectly-formatted-json-data
Feb 19, 2024
Merged
[Bug] Fix incorrectly formatted json data #812
alexjustesen
merged 45 commits into
v0.16.0-dev
from
fix-incorrectly-formatted-json-data
Feb 19, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📃 Description
This PR fixes incorrectly formatted json data in a Result's
datacolumn.FAQ
results_bad_jsonfor safe keeping.resultstableresults_bad_jsonwill remain in the database unless you decide to manually drop the table.Process
Database Migration (automated)
The following steps will occur automatically as part of the
0.16.0version.resultstoresults_bak_bad_jsonso theirs a copy of existing data.resultstable with an updated DDL.adminuser that manual action is required.Data Migration (manual)
The following steps will be required should users want to move their data over once they've upgraded to
v0.16.0. NOTE: this only applies to existing installs with existing results data.results_bad_jsontoresultswith the new DDL format.To-dos
🪵 Changelog
➕ Added
MigrateBadJsonResultsaction to move result data fromresults_bad_jsontoresults.Resultmodel attributes to get additional information fromdatacolumn.download_jitterip_addressisppacket_lossping_jitterresult_urlserver_hostserver_idserver_nameupload_jitterservicewhich preps for supporting multiple speedtest services (other than Ookla).ResultStatusenum to strictly set the result's status.ip_addressresult table filterstatusresult table filterupdated_atback to theResultmodel.✏️ Changed
Completedspeedtests.Resultstable to show additional columns and supportNumberhelper.formatForInfluxDB2()method to use model attributes.🔧 Fixed
datacolumn in theresultstable.🗑️ Removed
$fillable = []Result model attribute in favor of$guarded = []getJitterData()method from Result model, no longer needed.