feat: add webhook notifications

[darookee]

Changelog

Added

• webhook notifications channel with multiple recipients

Screenshots

[alexjustesen]

Thanks for the PR! I'm going to hold off reviewing/merging this until #736 is merged so we don't create extra work

[masterwishx]

can it be used for Discord notify?

[masterwishx]

Thanks for the PR! I'm going to hold off reviewing/merging this until #736 is merged so we don't create extra work

can it be merged now ?

[alexjustesen]

can it be merged now ?

Don't worry I haven't forgotten about this PR. Lots of moving pieces with trying to fix the time zone issue currently and then I should be able to come back to this.

[masterwishx]

@alexjustesen any news for this pr ?

[alexjustesen]

@darookee can you update your PR with the latest files and ensure tests pass?

[masterwishx]

@darookee can it be used for discord notification?

[darookee]

@darookee can you update your PR with the latest files and ensure tests pass?

The tests passed locally but I'm not sure how to run the linting job locally, my IDE does not give any errors though 🤷

[jonezy35]

I would LOVE to have this functionality. Is the plan to merge this?

[jonezy35]

@alexjustesen anything I can do to help make sure this is good to merge?

[alexjustesen]

I'm updating the PR as we speak to include recent changes. Need to do some 🤏 minor refactoring and then can merge it, eta prob later this weekend.

[alexjustesen]

For later me for testing: https://pipedream.com/requestbin

[alexjustesen]

Merging into add-webhook-notifications to make edits easier.

[evan326]

like masterwishx asked twice, can/how this be used with discord?

[masterwishx]

like masterwishx asked twice, can/how this be used with discord?

#1107 (reply in thread)

[darookee]

I don't know anything about discord webhooks but just looked it up in the discord docs and it looks like it does not accept requests without a specific json body. So no, with just this MR it is not possible to call a discord webhook.

[masterwishx]

I don't know anything about discord webhooks but just looked it up in the discord docs and it looks like it does not accept requests without a specific json body. So no, with just this MR it is not possible to call a discord webhook.

That's why I posted link above where @alexjustesen said it's not working for now but will fix it in future, I hope it will be very soon...

[darookee]

That's why I posted link above where @alexjustesen said it's not working for now but will fix it in future, I hope it will be very soon...

The link points to @evan326's comment 😬 (at least for me), that's why I wanted to clarify.

[masterwishx]

That's why I posted link above where @alexjustesen said it's not working for now but will fix it in future, I hope it will be very soon...

The link points to @evan326's comment 😬 (at least for me), that's why I wanted to clarify.

Sorry ,its my bad, fixed the link ...
if you can make the fix for discord we will be glad also .

[jonezy35]

like masterwishx asked twice, can/how this be used with discord?

I'd be happy to see if I can contribute to add the discord functionality! Life has been super hectic but if I get some time I'll see if I can do some work and open up a PR.

For now I've been using this. Works well and uses the API that speedtest exposes.

[jonezy35]

like masterwishx asked twice, can/how this be used with discord?

Discord functionality is added in PR #1196. As long as everything is good and it's merged Discord functionality will be up and running.