Added support X-Forwarded-Prefix+TrustedProxies#342
Merged
alexjustesen merged 6 commits intoalexjustesen:mainfrom Jan 28, 2023
Merged
Added support X-Forwarded-Prefix+TrustedProxies#342alexjustesen merged 6 commits intoalexjustesen:mainfrom
alexjustesen merged 6 commits intoalexjustesen:mainfrom
Conversation
Contributor
Author
|
@alexjustesen this line should be modified to be configured through an env variable ( I tried to use env() but there was an error so I forced it to '*'. You surely know how to do it, I don't. :) protected $proxies = '*'; |
alexjustesen
requested changes
Jan 21, 2023
alexjustesen
approved these changes
Jan 28, 2023
|
@alexdelprete @alexjustesen |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The X-Forwarded-Prefix was not configured to be used. Added it in $headers.
I also introduced a variable TRUSTED_PROXIES that should be an array of proxies that user can configure to be trusted. If the variable is not configured, the default is '*' which means any proxy will be trusted.
The use of this variable has to be validated because it should be an array, but we want users to only specify a comma-separated list of IPs, like this:
Maybe some logic/formatting is needed to achieve that. (tbr by @alexjustesen)
References: