Require recipient Telegram and validate bot token#324
Merged
alexjustesen merged 9 commits intoalexjustesen:mainfrom Jan 13, 2023
garanda21:main
Merged
Require recipient Telegram and validate bot token#324alexjustesen merged 9 commits intoalexjustesen:mainfrom garanda21:main
alexjustesen merged 9 commits intoalexjustesen:mainfrom
garanda21:main
Conversation
alexjustesen
requested changes
Jan 13, 2023
Owner
alexjustesen
left a comment
alexjustesen
left a comment
There was a problem hiding this comment.
Good catch on the validation, couple of things to adjust and make sure to run pint so code quality passes.
Contributor
Author
Submit new commit with changes! Let me know any other issues... |
alexjustesen
approved these changes
Jan 13, 2023
alexjustesen
approved these changes
Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This request fix
countagainstnullobject.As a bonus I've added a validation in case the
TELEGRAM_BOT_TOKENis empty or missing, with this we avoid error404 Chat not foundphp artisan config:cacheis necessary becase new files were created at/configfolder