Feat: Migrate Thresholds to Benchmarking model - #2884
Open
svenvg93 wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
Extends the benchmark/threshold system to close three specific asks — packet loss support, relative (ISP-baseline-percentage) thresholds, and recording an ISP baseline to compare against. The old flat
ThresholdSettings(a single global set of absolute download/upload/ping values) is replaced with aBenchmarkmodel — one row per metric (download, upload, ping, packet loss) — each configurable as either an absolute value or a percentage of a recorded ISP baseline.Closes #2155, #908, #1943.
🪵 Changelog
➕ Added
Benchmarksadmin resource (Settings → Benchmarks) — a table of the four metrics with an inline enable toggle and an edit-in-modal form for absolute/relative configuration✏️ Changed
*_on_threshold_failurerenamed to*_on_benchmark_failure(existing preferences carry over automatically)🗑️ Removed
ThresholdSettings, the oldThresholdssettings page, and theTHRESHOLD_*env vars/config keysApp\Helpers\Benchmark(logic moved onto the newBenchmarkmodel)📷 Screenshots