Add cron expression form validation #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@jocmp thanks for the PR! Can you do me a quick favor and address the code quality issues pint flagged? If you want to check locally you can run |
Using the CronExpression library, this addition ensures that a cron expression is valid in settings before allowing the user to save it.
jocmp
force-pushed
the
jc/validate-cron-expression
branch
from
33933a0 to
e51ee63
Compare
Contributor
Author
|
@alexjustesen sure thing. the branch is now up-to-date with those lints. |
alexjustesen
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the CronExpression library, this addition ensures that a cron expression is valid in settings before allowing the user to save it.
Addresses #278
Other notes
The
ValidCronExpressionLaravel rule was generated using the following commandBefore
Invalid cron expressions are saved without an error.
After
On Save, invalid cron expressions are not saved and the error is reflected in a UI message.