chore: remove hardcoded HTTP timeouts, use Laravel's 30s default#2789
Merged
Conversation
alexjustesen
approved these changes
May 25, 2026
arjayalsonado
added a commit
to arjayalsonado/speedtest-tracker
that referenced
this pull request
May 29, 2026
3a3bb18 Upstream Release v1.14.3 (alexjustesen#2793) e748623 chore: remove unused Laravel Telescope (alexjustesen#2792) 5845bd5 chore: remove Unifi integration (alexjustesen#2791) 26122d2 chore: remove Librespeed references (alexjustesen#2790) c5ae720 chore: remove hardcoded HTTP timeouts, use Laravel's 30s default (alexjustesen#2789)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
Removes hardcoded HTTP timeouts from
GetOoklaSpeedtestServersandAppriseChannel, letting both fall back to Laravel's built-in 30-second default. The previous 5-second timeout on the Ookla server list endpoint was to short in slow networks..Closes #2787
🪵 Changelog
🗑️ Removed
->timeout(5)fromGetOoklaSpeedtestServers— now uses Laravel's 30-second default->timeout(60)fromAppriseChannel— now uses Laravel's 30-second default->timeout(5)fromGetExternalIpAddress— now uses Laravel's 30-second default->timeout(5)fromCheckForInternetConnectionJob— now uses Laravel's 30-second default->timeout(10)fromRepository— now uses Laravel's 30-second default