[v2] refactor; Prometheus to handle null values and clean up#2705
Open
svenvg93 wants to merge 3 commits intoalexjustesen:2.xfrom
Open
[v2] refactor; Prometheus to handle null values and clean up#2705svenvg93 wants to merge 3 commits intoalexjustesen:2.xfrom
svenvg93 wants to merge 3 commits intoalexjustesen:2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
This PR significantly improves the Prometheus metrics implementation to follow best practices and standard conventions.
🪵 Changelog
➕ Added
speedtest_tracker_up- Exporter health indicator (always 1)speedtest_tracker_build_info- Application version metadataregisterGaugeIfNotNullfunction to skip null metrics. (Was already added and used in fix for v1)BREAKING_CHANGES.mdto track all the breaking changes during v2 development.✏️ Changed
download_bytes→download_bytes_per_second(explicit rate)upload_bytes→upload_bytes_per_second(explicit rate)download_bits→download_bits_per_second(explicit rate)upload_bits→upload_bits_per_second(explicit rate)downloaded_bytes→test_downloaded_bytes_total(cumulative total)uploaded_bytes→test_uploaded_bytes_total(cumulative total)🗑️ Removed
server_idlabelserver_countrylabel