Skip to content

Chore: Add helpertext for notification triggers #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexjustesen merged 3 commits into from
Jan 8, 2026
+17 −10
Merged

Chore: Add helpertext for notification triggers #2640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecfa0b1
add helpertext
svenvg93 Jan 8, 2026
be2257c
remove white line
svenvg93 Jan 8, 2026
cf0cba6
Merge branch 'main' into 2625-completed-test-with-thresholds
alexjustesen Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 14 additions & 9 deletions app/Filament/Pages/Settings/Notification.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,11 @@ public function form(Schema $schema): Schema
->columns(1)
->schema([
Checkbox::make('database_on_speedtest_run')
->label(__('settings/notifications.notify_on_every_speedtest_run')),

->label(__('settings/notifications.notify_on_every_speedtest_run'))
->helpertext(__('settings/notifications.notify_on_every_speedtest_run_helper')),
Checkbox::make('database_on_threshold_failure')
->label(__('settings/notifications.notify_on_threshold_failures')),
->label(__('settings/notifications.notify_on_threshold_failures'))
->helpertext(__('settings/notifications.notify_on_threshold_failures_helper')),
]),

Actions::make([
Expand Down Expand Up @@ -118,10 +119,11 @@ public function form(Schema $schema): Schema
->columns(1)
->schema([
Checkbox::make('mail_on_speedtest_run')
->label(__('settings/notifications.notify_on_every_speedtest_run')),

->label(__('settings/notifications.notify_on_every_speedtest_run'))
->helpertext(__('settings/notifications.notify_on_every_speedtest_run_helper')),
Checkbox::make('mail_on_threshold_failure')
->label(__('settings/notifications.notify_on_threshold_failures')),
->label(__('settings/notifications.notify_on_threshold_failures'))
->helpertext(__('settings/notifications.notify_on_threshold_failures_helper')),
]),

Repeater::make('mail_recipients')
Expand Down Expand Up @@ -176,10 +178,11 @@ public function form(Schema $schema): Schema
->columns(1)
->schema([
Checkbox::make('webhook_on_speedtest_run')
->label(__('settings/notifications.notify_on_every_speedtest_run')),

->label(__('settings/notifications.notify_on_every_speedtest_run'))
->helpertext(__('settings/notifications.notify_on_every_speedtest_run_helper')),
Checkbox::make('webhook_on_threshold_failure')
->label(__('settings/notifications.notify_on_threshold_failures')),
->label(__('settings/notifications.notify_on_threshold_failures'))
->helpertext(__('settings/notifications.notify_on_threshold_failures_helper')),
]),

Repeater::make('webhook_urls')
Expand Down Expand Up @@ -250,9 +253,11 @@ public function form(Schema $schema): Schema
->schema([
Checkbox::make('apprise_on_speedtest_run')
->label(__('settings/notifications.notify_on_every_speedtest_run'))
->helpertext(__('settings/notifications.notify_on_every_speedtest_run_helper'))
->columnSpanFull(),
Checkbox::make('apprise_on_threshold_failure')
->label(__('settings/notifications.notify_on_threshold_failures'))
->helpertext(__('settings/notifications.notify_on_threshold_failures_helper'))
->columnSpanFull(),
]),
Repeater::make('apprise_channel_urls')
Expand Down
4 changes: 3 additions & 1 deletion lang/en/settings/notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@
'webhook_hint_description' => 'These are generic webhooks. For payload examples and implementation details, view the documentation. For services like Discord, Ntfy etc please use Apprise.',

// Common notification messages
'notify_on_every_speedtest_run' => 'Notify on every scheduled speedtest run',
'notify_on_every_speedtest_run' => 'Notify on every completed scheduled speedtest run',
'notify_on_every_speedtest_run_helper' => 'This will send a notification for every completed scheduled speedtest run, only for healthy or unbenchmarked tests',
'notify_on_threshold_failures' => 'Notify on threshold failures for scheduled speedtests',
'notify_on_threshold_failures_helper' => 'This will send a notification when a scheduled speedtest fails any configured thresholds',

// Test notification messages
'test_notifications' => [
Expand Down