Skip to content

Conversation

@svenvg93
Copy link
Contributor

@svenvg93 svenvg93 commented Jan 3, 2026

📃 Description

This PR cleans up the ping logs for the PingHostname actions as the current ones make the logs harder to read. And there was a lot of duplicate data in there. Omitted the raw_output and lines

🪵 Changelog

✏️ Changed

  • Old Log
[2026-01-03 12:06:04] production.INFO: Pinged hostname {"host":"icanhazip.com","data":{"success":true,"error":null,"host":"icanhazip.com","packet_loss_percentage":0,"packets_transmitted":1,"packets_received":1,"options":{"timeout_in_seconds":5,"interval":1.0,"packet_size_in_bytes":56,"ttl":64},"timings":{"minimum_time_in_ms":3.776,"maximum_time_in_ms":3.776,"average_time_in_ms":3.776,"standard_deviation_time_in_ms":0.0},"raw_output":"PING icanhazip.com (104.16.185.241) 56(84) bytes of data.
64 bytes from 104.16.185.241: icmp_seq=1 ttl=58 time=3.78 ms

--- icanhazip.com ping statistics ---
1 packets transmitted, 1 received, 0% packet loss, time 0ms
rtt min/avg/max/mdev = 3.776/3.776/3.776/0.000 ms
","lines":[{"line":"64 bytes from 104.16.185.241: icmp_seq=1 ttl=58 time=3.78 ms","time_in_ms":3.78}]}} 
  • New Log
[2026-01-03 12:20:56] local.INFO: Pinged hostname {"host":"icanhazip.com","data":{"success":true,"error":null,"host":"icanhazip.com","packet_loss_percentage":0,"packets_transmitted":1,"packets_received":1,"options":{"timeout_in_seconds":5,"interval":1.0,"packet_size_in_bytes":56,"ttl":64},"timings":{"minimum_time_in_ms":4.088,"maximum_time_in_ms":4.088,"average_time_in_ms":4.088,"standard_deviation_time_in_ms":0.0}}} 

@svenvg93 svenvg93 requested a review from alexjustesen as a code owner January 3, 2026 12:25
@alexjustesen alexjustesen added the chore Nothing fancy, just needs to get done label Jan 3, 2026
@svenvg93 svenvg93 requested a review from alexjustesen January 3, 2026 13:33
@alexjustesen alexjustesen merged commit 82fdd6f into alexjustesen:main Jan 4, 2026
9 checks passed
@svenvg93 svenvg93 deleted the chore-cleanup-ping-log branch January 4, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Nothing fancy, just needs to get done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants