Skip to content

Fix: Apprise test button shown without saving #2627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexjustesen merged 2 commits into from
Jan 3, 2026
+7 −1
Merged

Fix: Apprise test button shown without saving #2627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1c2b91
only show text button after saving
svenvg93 Jan 3, 2026
24cbab6
pint
svenvg93 Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion app/Filament/Pages/Settings/Notification.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ public function form(Schema $schema): Schema
]),
Repeater::make('apprise_channel_urls')
->label(__('settings/notifications.apprise_channels'))
->helperText(__('settings/notifications.apprise_save_to_test'))
->schema([
TextInput::make('channel_url')
->label(__('settings/notifications.apprise_channel_url'))
Expand All @@ -274,7 +275,11 @@ public function form(Schema $schema): Schema
->action(fn (Get $get) => SendAppriseTestNotification::run(
channel_urls: $get('apprise_channel_urls'),
))
->hidden(fn (Get $get) => ! count($get('apprise_channel_urls'))),
->hidden(function () {
$settings = app(NotificationSettings::class);

return empty($settings->apprise_server_url) || ! count($settings->apprise_channel_urls ?? []);
}),
]),
]),
]),
Expand Down
1 change: 1 addition & 0 deletions lang/en/settings/notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
'apprise_channel_url' => 'Service URL',
'apprise_hint_description' => 'Apprise allows you to send notifications to 90+ services. You need to run an Apprise server and configure service URLs below.',
'apprise_channel_url_helper' => 'Use Apprise URL format. Examples: discord://WebhookID/Token, slack://TokenA/TokenB/TokenC',
'apprise_save_to_test' => 'Save your settings to test the notification.',
'test_apprise_channel' => 'Test Apprise',
'apprise_channel_url_validation_error' => 'Invalid Apprise URL. Must use Apprise format (e.g., discord://, slack://), not http:// or https://. See the Apprise documentation for more information',

Expand Down