Skip to content

Fix: Skip SkipSpeedtestJob when env var is empty #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexjustesen merged 2 commits into from
Jan 3, 2026
Merged

Fix: Skip SkipSpeedtestJob when env var is empty #2626

alexjustesen merged 2 commits into from
Jan 3, 2026
+2 −2

Conversation

@svenvg93
Copy link
Contributor

@svenvg93 svenvg93 commented Jan 3, 2026

📃 Description

This PR fixed that we skip the SkipSpeedtestJob when the SPEEDTEST_SKIP_IPS is empty. To no unnecessary check for the external IP.

📖 Documentation

N/A

🪵 Changelog

🔧 Fixed

  • Don't check for the External IP when SPEEDTEST_SKIP_IPS is not set.

@svenvg93 svenvg93 requested a review from alexjustesen as a code owner January 3, 2026 09:40
@svenvg93 svenvg93 changed the title Bug: Skip SkipSpeedtestJob when env var is empty Fix: Skip SkipSpeedtestJob when env var is empty Jan 3, 2026
@alexjustesen alexjustesen merged commit d0377e1 into alexjustesen:main Jan 3, 2026
9 checks passed
@svenvg93 svenvg93 deleted the bug-skip-job-when-env-not-set branch January 3, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexjustesen alexjustesen alexjustesen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@svenvg93 @alexjustesen