Refactor: Use strict comparison in chart widget filters#2498
Merged
alexjustesen merged 3 commits intoalexjustesen:mainfrom Dec 6, 2025
Merged
Conversation
iamgurjitsingh
force-pushed
the
refactor/use-strict-comparison-in-chart-widgets
branch
from
a260946 to
21975cd
Compare
Replace loose equality (==) with strict equality (===) when comparing filter values in all chart widgets. This improves type safety and follows PHP best practices. Changed in 6 widget files: - RecentDownloadChartWidget - RecentUploadChartWidget - RecentPingChartWidget - RecentJitterChartWidget - RecentDownloadLatencyChartWidget - RecentUploadLatencyChartWidget
iamgurjitsingh
force-pushed
the
refactor/use-strict-comparison-in-chart-widgets
branch
from
21975cd to
b3cee4b
Compare
alexjustesen
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace loose equality (==) with strict equality (===) when comparing
filter values in all chart widgets. This improves type safety and
follows PHP best practices.
Changed in 6 widget files: