Skip to content

chore: remove duplicate translation strings #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexjustesen merged 1 commit into from
Nov 30, 2025
Merged

chore: remove duplicate translation strings #2470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions app/Filament/Pages/Settings/Notification.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ public function form(Schema $schema): Schema
->columns(1)
->schema([
Checkbox::make('database_on_speedtest_run')
->label(__('settings/notifications.database_on_speedtest_run')),
->label(__('settings/notifications.notify_on_every_speedtest_run')),

Checkbox::make('database_on_threshold_failure')
->label(__('settings/notifications.database_on_threshold_failure')),
->label(__('settings/notifications.notify_on_threshold_failures')),
]),

Actions::make([
Expand Down Expand Up @@ -115,10 +115,10 @@ public function form(Schema $schema): Schema
->columns(1)
->schema([
Checkbox::make('mail_on_speedtest_run')
->label(__('settings/notifications.mail_on_speedtest_run')),
->label(__('settings/notifications.notify_on_every_speedtest_run')),

Checkbox::make('mail_on_threshold_failure')
->label(__('settings/notifications.mail_on_threshold_failure')),
->label(__('settings/notifications.notify_on_threshold_failures')),
]),

Repeater::make('mail_recipients')
Expand Down Expand Up @@ -173,10 +173,10 @@ public function form(Schema $schema): Schema
->columns(1)
->schema([
Checkbox::make('webhook_on_speedtest_run')
->label(__('settings/notifications.webhook_on_speedtest_run')),
->label(__('settings/notifications.notify_on_every_speedtest_run')),

Checkbox::make('webhook_on_threshold_failure')
->label(__('settings/notifications.webhook_on_threshold_failure')),
->label(__('settings/notifications.notify_on_threshold_failures')),
]),

Repeater::make('webhook_urls')
Expand Down
10 changes: 2 additions & 8 deletions lang/en/settings/notifications.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,28 +7,22 @@
// Database notifications
'database' => 'Database',
'database_description' => 'Notifications sent to this channel will show up under the 🔔 icon in the header.',
'database_on_speedtest_run' => 'Notify on every speedtest run',
'database_on_threshold_failure' => 'Notify on threshold failures',
'test_database_channel' => 'Test database channel',

// Mail notifications
'mail' => 'Mail',
'recipients' => 'Recipients',
'mail_on_speedtest_run' => 'Notify on every speedtest run',
'mail_on_threshold_failure' => 'Notify on threshold failures',
'test_mail_channel' => 'Test mail channel',

// Webhook
'webhook' => 'Webhook',
'webhooks' => 'Webhooks',
'webhook_on_speedtest_run' => 'Notify on every speedtest run',
'webhook_on_threshold_failure' => 'Notify on threshold failures',
'test_webhook_channel' => 'Test webhook channel',
'webhook_hint_description' => 'These are generic webhooks. For payload examples and implementation details, view the documentation.',

// Common notification messages
'notify_on_every_speedtest_run' => 'Notify on every speedtest run',
'notify_on_threshold_failures' => 'Notify on threshold failures',
'notify_on_every_speedtest_run' => 'Notify on every scheduled speedtest run',
'notify_on_threshold_failures' => 'Notify on threshold failures for scheduled speedtests',

// Test notification messages
'test_notifications' => [
Expand Down