Skip to content

Conversation

@svenvg93
Copy link
Contributor

@svenvg93 svenvg93 commented Nov 29, 2025

📃 Description

Fix notifications not being sent when thresholds are not used.
Please double check the logic :)

The original code used ! $result->healthy which means:

When healthy is null, ! null evaluates to true, so it would skip sending notifications ❌
When healthy is false, ! false evaluates to true, so it would skip ✅
When healthy is true, ! true evaluates to false, so it would send ✅

The fix uses $result->healthy === false which means:
When healthy is null, it will send notifications ✅
When healthy is false, it will skip ✅
When healthy is true, it will send ✅

closes #2456

@alexjustesen alexjustesen merged commit a216955 into alexjustesen:main Nov 29, 2025
9 checks passed
@svenvg93 svenvg93 deleted the 2456-fix-notifications-patch2 branch November 30, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Question] Email notifications and webhook notifications not working

2 participants