bug: fix notifications when not using thresholds #2464
Merged
alexjustesen merged 3 commits intoalexjustesen:mainfrom Nov 29, 2025
Merged
bug: fix notifications when not using thresholds #2464alexjustesen merged 3 commits intoalexjustesen:mainfrom
alexjustesen merged 3 commits intoalexjustesen:mainfrom
Conversation
alexjustesen
approved these changes
Nov 29, 2025
alexjustesen
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📃 Description
Fix notifications not being sent when thresholds are not used.
Please double check the logic :)
The original code used
! $result->healthywhich means:When healthy is null, ! null evaluates to true, so it would skip sending notifications ❌
When healthy is false, ! false evaluates to true, so it would skip ✅
When healthy is true, ! true evaluates to false, so it would send ✅
The fix uses
$result->healthy === falsewhich means:When healthy is null, it will send notifications ✅
When healthy is false, it will skip ✅
When healthy is true, it will send ✅
closes #2456